-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdClient (ticdc): Enable the pdClient forwarding function to make cdc more stable during network isolation between the PD leader #11076
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CharlesCheung96, sdojjy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: dongmen <[email protected]>
/hold |
Signed-off-by: dongmen <[email protected]>
/test all |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11076 +/- ##
================================================
+ Coverage 57.3926% 57.5924% +0.1998%
================================================
Files 851 851
Lines 125612 125855 +243
================================================
+ Hits 72092 72483 +391
+ Misses 48108 47990 -118
+ Partials 5412 5382 -30 |
/unhold |
/retest |
/retest |
2 similar comments
/retest |
/retest |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
… more stable during network isolation between the PD leader (pingcap#11076) close pingcap#10849
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #10849
What is changed and how it works?
Enable pdClient's forwarding function, make it can forward request to PD follower if cdc is network isolated with PD Leader.
Enabling forwarding will introduce additional network round trips between the PD follower and PD leader. However, since TiCDC doesn't call the PD API frequently, it won't affect TiCDC's performance.
So we decide to enable it by default.
Check List
Tests
This PR has been tested multiple times in the HA case [ha-ticdc-non-owner-random-to-pdleader-network-partition-last-for-10m]. The results indicate that it functions as expected:
The changefeed's lag is not affected by the network partition between CDC and the PD leader anymore.
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note