Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): add ut case for open protocol #11013

Merged
merged 1 commit into from
Jun 21, 2024
Merged

sink(ticdc): add ut case for open protocol #11013

merged 1 commit into from
Jun 21, 2024

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Apr 29, 2024

What problem does this PR solve?

Issue Number: close #11012

What is changed and how it works?

add ut case for open protocol to cover case when output-old-value is disabled and delete-only-output-handle-key-columns is enabled

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

 `None`.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 29, 2024
@sdojjy
Copy link
Member Author

sdojjy commented Apr 29, 2024

/retest-required

@codecov Codecov
Copy link

codecov bot commented Apr 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.5243%. Comparing base (ba6db07) to head (ffee17a).
Report is 70 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 64.4451% <100.0000%> (+2.7395%) ⬆️
dm 52.6646% <ø> (+1.4118%) ⬆️
engine 63.5518% <ø> (+0.1638%) ⬆️
Flag Coverage Δ
unit 59.5243% <100.0000%> (+2.1100%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11013        +/-   ##
================================================
+ Coverage   57.4142%   59.5243%   +2.1100%     
================================================
  Files           851        861        +10     
  Lines        125225     133616      +8391     
================================================
+ Hits          71897      79534      +7637     
- Misses        47936      48612       +676     
- Partials       5392       5470        +78

@sdojjy
Copy link
Member Author

sdojjy commented Apr 30, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 30, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 30, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-30 06:37:17.754375997 +0000 UTC m=+339191.511511571: ☑️ agreed by asddongmen.
  • 2024-04-30 06:37:35.316652601 +0000 UTC m=+339209.073788159: ☑️ agreed by 3AceShowHand.

@sdojjy
Copy link
Member Author

sdojjy commented Apr 30, 2024

/retest

@sdojjy
Copy link
Member Author

sdojjy commented May 17, 2024

/retest-required

6 similar comments
@sdojjy
Copy link
Member Author

sdojjy commented May 23, 2024

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented May 23, 2024

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented May 30, 2024

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented Jun 11, 2024

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented Jun 17, 2024

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented Jun 21, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot merged commit c001638 into pingcap:master Jun 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add an ut case for open protocol
3 participants
@sdojjy @3AceShowHand @asddongmen