Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli(ticdc): allow client authentication to be enabled without tls #11005

Merged
merged 8 commits into from
Apr 29, 2024
Merged

cli(ticdc): allow client authentication to be enabled without tls #11005

merged 8 commits into from
Apr 29, 2024

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Apr 28, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #11004

What is changed and how it works?

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

`None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 28, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 28, 2024
@CharlesCheung96
Copy link
Contributor Author

/test all

@codecov Codecov
Copy link

codecov bot commented Apr 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 57.4077%. Comparing base (ba6db07) to head (472de8a).

Additional details and impacted files
Components Coverage Δ
cdc 61.6869% <0.0000%> (-0.0187%) ⬇️
dm 51.2447% <ø> (-0.0081%) ⬇️
engine 63.4373% <ø> (+0.0494%) ⬆️
Flag Coverage Δ
unit 57.4077% <0.0000%> (-0.0066%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11005        +/-   ##
================================================
- Coverage   57.4142%   57.4077%   -0.0066%     
================================================
  Files           851        851                
  Lines        125225     125227         +2     
================================================
- Hits          71897      71890         -7     
- Misses        47936      47944         +8     
- Partials       5392       5393         +1

@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 28, 2024
@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 29, 2024
@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 29, 2024

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, flowbehappy, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [asddongmen,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 29, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-29 02:12:49.547198922 +0000 UTC m=+236923.304334496: ☑️ agreed by asddongmen.
  • 2024-04-29 04:06:07.753720591 +0000 UTC m=+243721.510856164: ☑️ agreed by hongyunyan.

@CharlesCheung96
Copy link
Contributor Author

/retest

1 similar comment
@CharlesCheung96
Copy link
Contributor Author

/retest

@CharlesCheung96
Copy link
Contributor Author

/test all

@CharlesCheung96
Copy link
Contributor Author

/retest

1 similar comment
@CharlesCheung96
Copy link
Contributor Author

/retest

@CharlesCheung96
Copy link
Contributor Author

/test cdc-integration-mysql-test tidb=d8219cfe18ed42bcd73eef99ac5d07bf07b9232e

@CharlesCheung96
Copy link
Contributor Author

/retest

1 similar comment
@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 36e9e1b into pingcap:master Apr 29, 2024
28 checks passed
@CharlesCheung96 CharlesCheung96 added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Apr 29, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11016.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Apr 29, 2024
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#11005
1129382 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 29, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Apr 30, 2024
@ti-chi-bot
cli(ticdc): allow client authentication to be enabled without tls (#1…
76cd913 
…1005) (#11016)

close #11004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongyunyan hongyunyan hongyunyan approved these changes

@asddongmen asddongmen asddongmen approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

@lidezhu lidezhu Awaiting requested review from lidezhu

Assignees
No one assigned
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow client authentication to be enabled without tls
5 participants
@CharlesCheung96 @ti-chi-bot @flowbehappy @asddongmen @hongyunyan