encoder (CDC) shrink the bytes.Buffer to reduce memory usage
#10417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ySQL/TiDB Signed-off-by: zhangjinpeng1987 <[email protected]>
Signed-off-by: zhangjinpeng1987 <[email protected]>
Signed-off-by: zhangjinpeng1987 <[email protected]>
Signed-off-by: zhangjinpeng1987 <[email protected]>
Signed-off-by: zhangjinpeng1987 <[email protected]>
ti-chi-bot
bot
added
release-note-none
|
/test dm-integration-test |
CharlesCheung96
approved these changes
Jan 4, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
asddongmen
approved these changes
Jan 4, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, CharlesCheung96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: zhangjinpeng1987 <[email protected]>
… name-refine Signed-off-by: zhangjinpeng1987 <[email protected]>
|
/test cdc-integration-storage-test |
|
/test dm-integration-test |
3 similar comments
|
/test dm-integration-test |
|
/test dm-integration-test |
|
/test dm-integration-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #10416
What is changed and how it works?
bytes.Bufferhas no way to shrink its internalbuf, we re-create a newbytes.Bufferfor csv/canal encoder after itsbytes.Buffer's memory usage exceeded specified threshold (1MB, because 1MB is not trivial in terms of memory allocator and TiCDC memory usage) instead of reusing it.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note