dm: support MySQL 8.0 GA #10415
dm: support MySQL 8.0 GA #10415
Conversation
ti-chi-bot
bot
added
release-note
|
/cc @lance6716 |
|
/retest |
|
/cc @lance6716 |
dm/pkg/checker/mysql_server.go
Outdated
| var SupportedVersion = map[string]struct { | ||
| Min MySQLVersion | ||
| Max MySQLVersion | ||
| }{ | ||
| "mysql": { | ||
| MySQLVersion{5, 6, 0}, | ||
| MySQLVersion{8, 0, 0}, | ||
| MySQLVersion{8, 0, 34}, |
There was a problem hiding this comment.
why do we choose this version?
https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-35.html
There was a problem hiding this comment.
right, supported version should be < 8.0.36
There was a problem hiding this comment.
can you explain the reason why we choose that version? currently latest MySQL's release version?
There was a problem hiding this comment.
yes, I initially tend to support 8.0.x, which means we support all the versions starting with 8.0, but in the code we need to be specific about the version, so I use the latest MySQL's release version
There was a problem hiding this comment.
You can use MySQLVersion{8, 1, 0} then
|
/retest |
1 similar comment
|
/retest |
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/cc @D3Hunter |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #10405
What is changed and how it works?
DM supports MySQL 8.0 GA.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No.
Do you need to update user documentation, design documentation or monitoring documentation?
pingcap/docs#15959
pingcap/docs-cn#15985
Release note