Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codec(ticdc): simple protocol support avro encoding format #10359

Merged
merged 53 commits into from
Jan 8, 2024

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #10358

What is changed and how it works?

  • add hand writing avro schema, which can be used to encode and decode avro binary data.
  • add unit test to cover encoding & decoding functionality correctness.
  • add integration test to cover simple avro encoding format correctness.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 25, 2023
@asddongmen asddongmen self-requested a review December 26, 2023 01:53
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 26, 2023
@purelind
Copy link
Collaborator

/retest

@ti-chi-bot ti-chi-bot bot added the affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. label Jan 4, 2024
@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-kafka-test

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 8, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-08 04:32:56.648759642 +0000 UTC m=+244966.233013314: ☑️ agreed by asddongmen.
  • 2024-01-08 05:42:33.012737563 +0000 UTC m=+249142.596991254: ☑️ agreed by sdojjy.

@ti-chi-bot ti-chi-bot bot merged commit 1372b29 into pingcap:master Jan 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simple protocol support avro as encoding format
4 participants