(pkg/generateDeleteSQL) reduce redundant calculation #10312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhangjinpeng1987 <[email protected]>
ti-chi-bot
bot
added
the
release-note-none
ti-chi-bot
bot
added
the
size/S
Signed-off-by: zhangjinpeng1987 <[email protected]>
Signed-off-by: zhangjinpeng1987 <[email protected]>
Signed-off-by: zhangjinpeng1987 <[email protected]>
|
/test dm-integration-test |
|
/test cdc-integration-mysql-test |
|
/test dm-integration-test |
lance6716
approved these changes
Dec 16, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
asddongmen
approved these changes
Dec 19, 2023
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
hicqu
approved these changes
Dec 19, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, hicqu, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/test cdc-integration-kafka-test |
|
/test dm-integration-test |
|
/test cdc-integration-mysql-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #10311
What is changed and how it works?
Use index heuristic common columns count as a hint when pre-allocate space for slice to reduce redundant calculation, instead of calculating how many columns current primary key or unique index contains for each row.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note