ttl: rollback the scan trasnaction even if the BEGIN
failed. (#58943)
#58950
+132
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #58943
What problem does this PR solve?
Issue Number: close #58900
Problem Summary:
Previously, the
RunInTxn
will only rollback the transaction after theBEGIN
runs successfully. However, if theBEGIN
is killed after setting the transaction status, it can still leave a valid transaction. We'll need to alsoROLLBACK
it.The effect is that when we are cancelling a TTL task (scaling the workers, stepping out of the TTL window, stopping the TTL function...), a session with valid transaction may pollute the session pool.
What changed and how does it work?
Move the
defer ... ROLLBACK
logic to the top of theRunInTxn
function.Check List
Tests
Release note