Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix insert gc failed due to slow schema reload #57742

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Tristan1900
Copy link
Contributor

@Tristan1900 Tristan1900 commented Nov 26, 2024

What problem does this PR solve?

Issue Number: close #57743

Problem Summary:

What changed and how does it work?

Wait until schema info finished reloading before proceeding to the rest of the restore process,
Added test to first to reproduce the issue and then add the fix to verify the issue has been fixed (TDD)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed loading schema taking long time during restore causing insertGc row and other operations to fail  

Copy link

ti-chi-bot bot commented Nov 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2024
Copy link

tiprow bot commented Nov 26, 2024

Hi @Tristan1900. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Wenqi Mou <[email protected]>
@Tristan1900 Tristan1900 marked this pull request as ready for review November 27, 2024 17:29
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 27, 2024
Signed-off-by: Wenqi Mou <[email protected]>
@Tristan1900
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 27, 2024
@Tristan1900 Tristan1900 changed the title br: reproduce insert gc failed due to slow schema reload br: fix insert gc failed due to slow schema reload Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 30 lines in your changes missing coverage. Please review.

Project coverage is 74.7739%. Comparing base (2b03447) to head (b9d541a).
Report is 13 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57742        +/-   ##
================================================
+ Coverage   72.8732%   74.7739%   +1.9007%     
================================================
  Files          1677       1723        +46     
  Lines        464202     475096     +10894     
================================================
+ Hits         338279     355248     +16969     
+ Misses       105016      97634      -7382     
- Partials      20907      22214      +1307     
Flag Coverage Δ
integration 49.1942% <45.4545%> (?)
unit 72.2527% <0.0000%> (-0.0177%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 60.4999% <55.5555%> (+14.7963%) ⬆️

@Tristan1900
Copy link
Contributor Author

/assign @Leavrth

@Tristan1900
Copy link
Contributor Author

/assign @lance6716

// IsLeaseExpired returns whether lease has expired
func (do *Domain) IsLeaseExpired() bool {
startReloadTime := time.Now()
return time.Since(startReloadTime) > do.schemaLease
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function seems never return true?
because time.Since(time.Now()) is close to zero.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are absolutely right, that's a dumb mistake. but why did the test passed, let me take a look!

Signed-off-by: Wenqi Mou <[email protected]>
Copy link

ti-chi-bot bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lance6716, leavrth, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/needs-triage-completed ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br: wait till info schema loading finished before proceeding to the rest of the PiTR restore
4 participants