-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: fix insert gc failed due to slow schema reload #57742
base: master
Are you sure you want to change the base?
br: fix insert gc failed due to slow schema reload #57742
Conversation
Skipping CI for Draft Pull Request. |
Hi @Tristan1900. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Wenqi Mou <[email protected]>
8b47d90
to
94f9230
Compare
Signed-off-by: Wenqi Mou <[email protected]>
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57742 +/- ##
================================================
+ Coverage 72.8732% 74.7739% +1.9007%
================================================
Files 1677 1723 +46
Lines 464202 475096 +10894
================================================
+ Hits 338279 355248 +16969
+ Misses 105016 97634 -7382
- Partials 20907 22214 +1307
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/assign @Leavrth |
/assign @lance6716 |
pkg/domain/domain.go
Outdated
// IsLeaseExpired returns whether lease has expired | ||
func (do *Domain) IsLeaseExpired() bool { | ||
startReloadTime := time.Now() | ||
return time.Since(startReloadTime) > do.schemaLease |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function seems never return true?
because time.Since(time.Now()) is close to zero.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are absolutely right, that's a dumb mistake. but why did the test passed, let me take a look!
Signed-off-by: Wenqi Mou <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #57743
Problem Summary:
What changed and how does it work?
Wait until schema info finished reloading before proceeding to the rest of the restore process,
Added test to first to reproduce the issue and then add the fix to verify the issue has been fixed (TDD)
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.