Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br-pitr-manual: remove an unnecessary quotation mark #19535

Merged
merged 8 commits into from
Nov 29, 2024
Merged

br-pitr-manual: remove an unnecessary quotation mark #19535

merged 8 commits into from
Nov 29, 2024

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Nov 29, 2024 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

As in the title

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. ONCALL Relates to documentation oncall. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Nov 29, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 29, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2024
qiancai
qiancai commented Nov 29, 2024
View reviewed changes
br/br-pitr-manual.md Outdated Show resolved Hide resolved
qiancai
qiancai commented Nov 29, 2024
View reviewed changes
br/br-pitr-manual.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 29, 2024

@Leavrth: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai qiancai added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm and removed needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 29, 2024
@qiancai
Copy link
Collaborator Author

qiancai commented Nov 29, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 29, 2024
@qiancai qiancai added the area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). label Nov 29, 2024
@ti-chi-bot ti-chi-bot bot merged commit e781021 into pingcap:master Nov 29, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #19536.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 29, 2024
@qiancai @ti-chi-bot
br-pitr-manual: remove an unnecessary quotation mark (pingcap#19535)
79a2a2e
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 29, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #19537.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 29, 2024
@qiancai @ti-chi-bot
This is an automated cherry-pick of pingcap#19535
e7e3fa1 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 29, 2024
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Nov 29, 2024
@ti-chi-bot
br-pitr-manual: remove an unnecessary quotation mark (#19535) (#19536)
8c412cf
ti-chi-bot bot pushed a commit that referenced this pull request Nov 29, 2024
@ti-chi-bot
br-pitr-manual: remove an unnecessary quotation mark (#19535) (#19537)
34fab29
This was referenced Nov 29, 2024
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Nov 29, 2024
@ti-chi-bot
br-pitr-manual: remove an unnecessary quotation mark (#19535) (#19537) (
bb89037 
#19541)
ti-chi-bot bot pushed a commit that referenced this pull request Nov 29, 2024
@ti-chi-bot
br-pitr-manual: remove an unnecessary quotation mark (#19535) (#19537) (
8bf6f45 
#19540)
ti-chi-bot bot pushed a commit that referenced this pull request Nov 29, 2024
@ti-chi-bot
br-pitr-manual: remove an unnecessary quotation mark (#19535) (#19537) (
9281c82 
#19542)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leavrth Leavrth Leavrth approved these changes

Assignees
No one assigned
Labels
approved area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qiancai @ti-chi-bot @Leavrth