Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing extensions on imports #344

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Kyle772
Copy link

@Kyle772 Kyle772 commented Dec 19, 2024

This may resolve #61

Some environments using .ts files may fail when the imports inside the lib are pointing to .js files specifically. Anecdotally this solves the problem on my RN expo project but should probably be tested in other environments.

Tested on:
Expo 51
React Native 74

PR generated by doing a regex find and replace with the following in case it needs to be adjusted further
find: from\s+(['"](\.{1,2}\/)+[^'"]+)\.js(['"])
replace: from $1$3

Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: ea672e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to resolve file when using React Native
1 participant