Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to rhinestone audited contracts #314

Conversation

yoanslvy
Copy link
Contributor

@yoanslvy yoanslvy commented Oct 29, 2024

It seems like during the audit of the new rhinestone safe7579 adapter contracts, they updated the code to use the safe7579Adapter domain in the typehash of the signature (before the audit they used the launchpad address). Also, it seems like the attester is needed for the creation of the wallet, if you don't put any attester it will revert.

For now I did not force it in the code so you have to input it in the function as such:

 const safeAccount = await toSafeSmartAccount({
      client: publicClient,
      owners: [owner],
      version: "1.4.1",
      entryPoint: {
          address: entryPoint07Address,
          version: "0.7",
      },
      safe4337ModuleAddress: "0x7579EE8307284F293B1927136486880611F20002", 
      erc7579LaunchpadAddress: "0x7579011aB74c46090561ea277Ba79D510c6C00ff", 
      attesters: ["0x000000333034E9f539ce08819E12c1b8Cb29084d"],
      attestersThreshold: 1
})
          

Copy link

changeset-bot bot commented Oct 29, 2024

🦋 Changeset detected

Latest commit: b293e3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
permissionless Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@plusminushalf
Copy link
Contributor

Thanks, @yoanslvy, for helping us fix the new 7579 contracts!

There are a few tests that are currently failing:

  1. erc7579/installModules.test.ts
  2. erc7579/installModule.test.ts
  3. erc7579/uninstallModules.test.ts
  4. erc7579/uninstallModule.test.ts
  5. erc7579/isModuleInstalled.test.ts

Could you help us resolve these issues? Please let me know if there’s anything off with the way I've set up the tests. I’ve already pushed the test changes to your pull request.

You can view the report here: https://github.com/pimlicolabs/permissionless.js/actions/runs/11573741377/job/32216490198?pr=314

yoanslvy and others added 2 commits October 30, 2024 10:09
* feat: update safe7579 tests

* feat: update deployments

* chore: format

---------

Co-authored-by: kopy-kat <[email protected]>
@yoanslvy
Copy link
Contributor Author

yoanslvy commented Oct 31, 2024

Tests have been updated with the good help of @kopy-kat , should be good to go now !

@plusminushalf plusminushalf merged commit c5b6cde into pimlicolabs:main Nov 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants