refactoring

pimcore · Oct 9, 2024 · 30b67d1 · 30b67d1
1 parent 20bb37d
commit 30b67d1
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/assets/js/src/core/components/select/select.tsx b/assets/js/src/core/components/select/select.tsx
@@ -35,18 +35,20 @@ export const Select = forwardRef<RefSelectProps, SelectProps>(({ customIcon, cus
   const { styles } = useStyles()
 
   const withCustomIcon = !isEmptyValue(customIcon)
+  const isStatusWarning = status === 'warning'
+  const isStatusError = status === 'error'
 
   const selectContainerClassNames = cn(styles.selectContainer, {
-    [styles.selectContainerWarning]: status === 'warning',
-    [styles.selectContainerError]: status === 'error'
+    [styles.selectContainerWarning]: isStatusWarning,
+    [styles.selectContainerError]: isStatusError
   })
   const selectClassNames = cn(styles.select, {
     [styles.selectWithCustomIcon]: withCustomIcon
   })
   const customIconClassNames = cn(styles.customIcon, 'custom-select-icon', {
     [styles.customIconActive]: isActive || isFocus,
-    [styles.customIconWarning]: (isActive || isFocus) && status === 'warning',
-    [styles.customIconError]: (isActive || isFocus) && status === 'error'
+    [styles.customIconWarning]: (isActive || isFocus) && isStatusWarning,
+    [styles.customIconError]: (isActive || isFocus) && isStatusError
   })
 
   const handleClick = (): void => { setIsActive(!isActive) }