Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the user's timezone in the version preview and in CSV exports #548

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

markus-moser
Copy link
Contributor

@markus-moser markus-moser commented Jun 3, 2024

@markus-moser markus-moser added this to the 1.5.0 milestone Jun 3, 2024
@markus-moser markus-moser marked this pull request as draft June 3, 2024 13:31
@markus-moser
Copy link
Contributor Author

Tests will work as soon as pimcore/pimcore#17117 gets released.

@markus-moser
Copy link
Contributor Author

We need to wait with the merge for the next minor release of the core otherwise tests will fail.

@blankse
Copy link
Contributor

blankse commented Jun 6, 2024

@markus-moser You need to bump the Pimcore Version in the composer.json when this is a requirement

@markus-moser
Copy link
Contributor Author

@blankse Yes, we will need to do this anyways during the release - we have some other PR pairs like that.

markus-moser and others added 3 commits June 11, 2024 16:32
# Conflicts:
#	public/js/pimcore/functions.js
# Conflicts:
#	public/js/pimcore/functions.js
Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kingjia90 kingjia90 merged commit a764725 into 1.x Jun 18, 2024
9 checks passed
@kingjia90 kingjia90 deleted the user-timezone branch June 18, 2024 09:43
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants