Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove code of old 11_aerosols realizations #606

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Jun 3, 2024

  • remove reporting code for the postIIASA and postECLIPSE realizations of the 11_aerosols module that maybe have existed in ancient times before we moved to github in 2019.
  • The only thing I have done is remove everything that is behind the if switches with the two old realizations. Unfortunately, the full diff is basically unreadable. Check commits separately. The adjust whitespace is really just removing two blanks, but the diff looks terrible.
  • https://mattermost.pik-potsdam.de/rd3/pl/6jy76asjsif5dg6a8q8ei4u9bh
  • in line with Drop Backwards Compatibility #524

@orichters orichters requested a review from gabriel-abrahao June 3, 2024 12:54
@gabriel-abrahao
Copy link
Contributor

Looks good to me, and I also can't see any use for that old code now.

@orichters orichters merged commit 7927dad into pik-piam:master Jun 5, 2024
2 checks passed
@orichters orichters deleted the exogains branch August 19, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants