Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move deletePlus to piamUtils package #589

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Conversation

fbenke-pik
Copy link
Contributor

No description provided.

@fbenke-pik fbenke-pik requested a review from orichters April 17, 2024 16:49
Copy link
Contributor

@orichters orichters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot just drop the export, given that those scripts (mostly from remindmodel) still rely on it:

So while I fear to annoy you with backwards compatibility issues, I think we should still make sure the latest remind release does not fail. It seems there is the option to simply reexport and imported function, and I think that is what we should do here: See this discussion and this example.

And of course one would need to adapt those packages.

@fbenke-pik
Copy link
Contributor Author

I added reexport for backwards compatibility. Thanks for pointing out this option.

For adjustments in the packages you named:

@fbenke-pik fbenke-pik requested a review from orichters April 18, 2024 09:35
R/reexport.R Outdated Show resolved Hide resolved
@fbenke-pik fbenke-pik merged commit 261e25f into pik-piam:master Apr 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants