fix logging for refpolicycost, run one of the tests with refpolicycost = NULL #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
orichters
commented
Feb 27, 2024
orichters
commented
- add first_found to reportPrices. The variable was renamed recently (this commit)
- fix logging for refpolicycost and don't show inconsistent information. Also run test with refpolicycost=NULL, at least on the cluster, to make sure both with and without is tested. Would have avoided The negation seems to have survived unintentionally #543. (this commit)
orichters
changed the title
fbenke-pik
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.