remove maglcass::dimSums() imports #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- since magclass 6.0.0 changed dimSums() behaviour, remind2 uses a local dimSums() (see pik-piam#98) - so dimSums() was imported, then immediately overwritten by the local dimSums() version in the remind2 scope
fbenke-pik
approved these changes
Feb 19, 2024
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
merged commit 7bc8a53
into
pik-piam:master
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dimSums()behaviour, remind2 uses a localdimSums()(see fix issues with magclass 6.0.0 #98)dimSums()was imported, then immediately overwritten by the localdimSums()version in theremind2scope