-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore condition for project-specific emissions reporting #523
Restore condition for project-specific emissions reporting #523
Conversation
…-emissions-inconsistency
…-emissions-inconsistency
The test also fails for ECEMF. The problem is the variable So it crashes with
So you just have to make sure that |
ok, will do, thank you! For the record: I didn't realize that the mapping tests can be skipped and buildLibrary still is successful when running locally (which is what had happened here) |
…/remind2 into fix-emissions-inconsistency
R/reportEmi.R
Outdated
setNames(dimSums(vm_feedstockEmiUnknownFate, dim=3)* GtC_2_MtCO2, | ||
setNames((dimSums(vm_feedstockEmiUnknownFate, dim=3))* GtC_2_MtCO2, | ||
"Emi|CO2|Energy|Waste|+|Feedstocks unknown fate (Mt CO2/yr)"), | ||
setNames(dimSums(vm_incinerationEmi, dim=3)* GtC_2_MtCO2, | ||
setNames((dimSums(vm_incinerationEmi, dim=3))* GtC_2_MtCO2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is up with those brackets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ups, I was trying something and forgot to delete those. Now I did.
…-emissions-inconsistency
I ran all the mapping tests manually and they all passed (with warnings of missing variables for some and the gaps in the summation checks, as expected) |
This restores a condition designed to enable the reporting of industry emissions from feedstocks with an ad-hoc ex-post fix designed for the Ariadne project. Used when feedstock flows are not available (older remind versions).
This PR is NOT intended to fix the inconsistencies in emissions accounting. That will come in this one: #530 .