Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust LCOE reporting to renamed variable vm_costInvTeAdj #504

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

JakobBD
Copy link
Contributor

@JakobBD JakobBD commented Jan 11, 2024

Minor bugfix to adjust LCOE reporting to this commit changing this variable name from v_costInvTeAdj to vm_costInvTeAdj.

@JakobBD JakobBD requested a review from fbenke-pik January 11, 2024 14:01
@fbenke-pik
Copy link
Contributor

Shouldn't @sophiefuchs be the reviewer for this one?

@JakobBD JakobBD requested review from sophiefuchs and tabeado and removed request for fbenke-pik January 11, 2024 14:29
@tabeado
Copy link
Contributor

tabeado commented Jan 11, 2024

As far as I can see, not only v_costInvTeAdj but also v_costInvTeDir were changed in the Remind commit. Thus maybe also update the name v_costInvTeDir to vm_costInvTeDir?

@JakobBD
Copy link
Contributor Author

JakobBD commented Jan 11, 2024

The new name was somehow already present in the readGDX command, so that it didn't cause errors, but now I changed the R variable name as well.

@tabeado
Copy link
Contributor

tabeado commented Jan 12, 2024

great, thank you!

@JakobBD JakobBD merged commit 36bc28e into master Jan 12, 2024
4 checks passed
@JakobBD JakobBD deleted the adjust_renamed_variable.fix branch February 5, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants