Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix of previously added SE variable for specific GDX files #481

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

fschreyer
Copy link
Contributor

Bugfix for #480 to work with this GDX:

https://rse.pik-potsdam.de/data/example/remind2_test-Ariadne_fulldata.gdx

I tested the PR only with https://rse.pik-potsdam.de/data/example/remind2_test-convGDX2MIF_fulldata.gdx and I presumebuildLibrary does so, too. I would suggest this GDX file to also feature make test. What do you think, @LaviniaBaumstark?

Felix Schreyer added 2 commits October 12, 2023 14:29
… GDX files in which pm_fuExtrOwnCons is always zero in a region
@fschreyer fschreyer requested a review from orichters October 12, 2023 15:27
Copy link
Contributor

@orichters orichters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this gdx is featured in make test, that is why it failed for me. The question is rather why the test did not fail in your case…

@fschreyer fschreyer merged commit 705da61 into pik-piam:master Oct 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants