read in IEA Energy Efficiency Indicators database #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for bringing up the source name again. But I was wondering, if |
robinhasse
requested changes
Apr 18, 2024
| for (domain in c("INDUSTRY", "TRANSPORT", "RESIDENTIAL", "SERVICES")) { | ||
| data <- rbind(data, fread( | ||
| file = file.path("2023", paste0("IEA - EEI ", domain, ".TXT")), | ||
| col.names = c("CARBON_INDICATOR", "END_USE", "TIME", "COUNTRY", "VALUE"), |
There was a problem hiding this comment.
Suggested change
| col.names = c("CARBON_INDICATOR", "END_USE", "TIME", "COUNTRY", "VALUE"), | |
| col.names = c("ITEM", "ENDUSE", "TIME", "COUNTRY", "VALUE"), |
I suggest different dimension names. This is tricky, as IEA mixes very different types of data:
col.names[1]: Indicators, Activity, Products --> ITEMcol.names[2]: End use, blank for activity --> ENDUSE
robinhasse
reviewed
Apr 18, 2024
Comment on lines
4
to
5
| #' @importFrom data.table fread := | ||
| #' @importFrom dplyr %>% filter mutate distinct |
There was a problem hiding this comment.
Suggested change
| #' @importFrom data.table fread := | |
| #' @importFrom dplyr %>% filter mutate distinct | |
| #' @importFrom data.table fread | |
| #' @importFrom dplyr %>% filter mutate distinct | |
| #' @importFrom magclass as.magpie |
robinhasse
reviewed
Apr 18, 2024
| #' | ||
| #' @author Falk Benke | ||
| #' @param x MAgPIE object to be converted | ||
| #' @importFrom madrat toolCountry2isocode toolCountryFill |
There was a problem hiding this comment.
Suggested change
| #' @importFrom madrat toolCountry2isocode toolCountryFill | |
| #' @importFrom madrat toolCountry2isocode toolCountryFill | |
| #' @importFrom magclass getItems getItems<- |
robinhasse
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.