Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings for REMIND inputdata generation #109

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

fbenke-pik
Copy link
Contributor

@fbenke-pik fbenke-pik commented Mar 21, 2024

This PR fixes a few warnings produced when generating the REMIND inputdata.

  • remove renaming messages when reading in excel files by setting .name_repair = "unique_quiet"
  • suppress warnings when converting data frame columns to numeric (NAs introduced)
  • set verbosity to lowest when calling toolCountryFill
  • remove some regions that cannot be converted by toolCountryFill and toolCountry2isocode and will be dropped anyways
  • set warnNA = FALSE when calling calcOutput
  • explicitly set no_remove_warning to affected countries when calling toolCountryFill
  • explicitly set by argument in joins

validation on the cluster

madrat::compareData("/p/projects/rd3mod/inputdata/output/rev6.75falk-before_2b1450bc_remind.tgz",
                    "/p/projects/rd3mod/inputdata/output/rev6.75falk-compare_2b1450bc_remind.tgz")

madrat::compareData("/p/projects/rd3mod/inputdata/output/rev6.75falk-before_62eff8f7_remind.tgz",
                    "/p/projects/rd3mod/inputdata/output/rev6.75falk-compare_62eff8f7_remind.tgz")

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 0.11%. Comparing base (d2e1108) to head (b458459).

Files Patch % Lines
R/calcMacBaseLandUse.R 0.00% 19 Missing ⚠️
R/convertMAgPIE.R 0.00% 4 Missing ⚠️
R/convertEEA_EuropeanEnvironmentAgency.R 0.00% 3 Missing ⚠️
R/readEEA_EuropeanEnvironmentAgency.R 0.00% 3 Missing ⚠️
R/convertEDGAR8.R 0.00% 2 Missing ⚠️
R/convertEU_ReferenceScenario.R 0.00% 2 Missing ⚠️
R/convertEDGAR.R 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #109      +/-   ##
=========================================
- Coverage    0.11%   0.11%   -0.01%     
=========================================
  Files         316     316              
  Lines       17394   17397       +3     
=========================================
  Hits           20      20              
- Misses      17374   17377       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fbenke-pik fbenke-pik marked this pull request as ready for review March 21, 2024 14:08
@fbenke-pik fbenke-pik changed the title fix warnings fix warnings for REMIND inputdata generation Mar 21, 2024
@fbenke-pik fbenke-pik merged commit f22659b into pik-piam:master Mar 21, 2024
4 checks passed
@fbenke-pik fbenke-pik deleted the fixwarnings branch July 10, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants