Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings lucode2::buildLibrary() #312

Merged
merged 10 commits into from
Dec 13, 2024

Conversation

ahagen-pik
Copy link
Contributor

Purpose of this PR

Fixes all 270 'no visible binding' NOTES of lucode2::buildLibrary() from R CMD Check which come from NSE in the data.table package as well as missing function import.

Checklist:

  • I used ./test-standard-runs to compare and archive the changes introduced by this PR in /p/projects/edget/PRchangeLog/
  • I additionally checked that iterativeEDGETransport works without problem, REMIND is running for >15 iterations

Further information (optional):

  • Test runs are here: /p/projects/edget/PRchangeLog/20241212_fixWarningsEDGET
  • Comparison of results (what changes by this PR?): Nothing on the functionality/simulation results, but lucode2::buildLibrary() is clean again.

Copy link
Contributor

@fbenke-pik fbenke-pik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@jmuessel
Copy link
Contributor

Wow, great job!

@ahagen-pik ahagen-pik merged commit e9b554e into pik-piam:master Dec 13, 2024
2 checks passed
@ahagen-pik ahagen-pik deleted the fixWarnings branch December 13, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants