add docker build instructions, multistage build #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piglei
reviewed
Jan 6, 2025
README.md
Outdated
| @@ -53,6 +53,26 @@ uv pip install ai-vocabulary-builder | |||
| # uvx --from ai-vocabulary-builder aivoc notebook | |||
| ``` | |||
|
|
|||
| [docker](https://hub.docker.com/_/python) | |||
There was a problem hiding this comment.
It would be nice if you put this section in a separate CONTRIBUTING.md file, because only developers will need to build the image themselves. For users, I will upload the image to the docker hub and the README will only mention it via docker run ....
Dockerfile
Outdated
| COPY --from=builder /app/voc_builder ./voc_builder | ||
| COPY --from=builder /usr/local/lib/python3.10/site-packages /usr/local/lib/python3.10/site-packages | ||
| EXPOSE 10000 | ||
| CMD ["python", "-m", "voc_builder.main", "notebook", "--host", "0.0.0.0", "--port", "10000"] |
There was a problem hiding this comment.
I would prefer the image to use the default port 16093; How about an example about customizing the host and port, it would be a common practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.