Fix loop not stopping when clicking looping sound #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking on a sound's three dots, then on the loop icon, the sound will begin to play in a loop. Click again on the sound, and it should stop playing, but it doesn't.
I believe this happened because Foundry doesn't trigger an "end" event on a looping sound, so that event listener was never called. By handling the loop ourselves, this issue no longer happens. It does, however, cause an issue with Loops with delays. Without the modification to the delayIntervals, the sound would play once more after the loop is stopped.
Also, thank you for fixing the module for v12. I used it a while ago, then stopped, and now needed it again only to find it gone. Happy to see someone kept it working for now.