-
-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About Page & Fancybox / Portfolio Template #352
Conversation
So, I've integrated all of the duplicate styles back into their original sections, and I've moved everything else that was necessary up into the relevant sections. The only items that haven't been merged above are the things I'm still working through. These remaining styles have to do with the "standalone" gallery. Most of it relates to an ugly hack that I'd like to improve, but I'm not sure how to. Think back to before the carousel, when the images were just arranged side-by-side on the page. By making the standalone items "inline-block", I somehow introduced a small amount of space at the bottom, where the My "ugly hack" was to remove all line height from the containing I don't see a reason to hold back this PR because of it, but I'm probably going to attach some kind of "ugly hack" note to it when I move it up into the regular section. Maybe a line that reminds us / tells a future person to reference #352 for details. |
Done? Maybe? lol. Let me know if you find anything that needs to be fixed. Otherwise... I guess this is awaiting review. 😄 Unbelievable that this has taken almost three months to finalize. Especially when most of the written content was done in the first few commits. Sometimes it's crazy how small projects like this can scale up once you get going. |
|
||
## Flexibility and Customization | ||
|
||
Pico's code base aims to be just as "stupidly simple" as Pico is easy to use. While the core of Pico remains slim and lightweight, Pico has two very large avenues of customization, [Themes][] and [Plugins][]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to update these links in #358 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update About page URLs
It's been on my to-do list over there for awhile now. 😃
I've read through everything, absolutely great work, it's just perfect! 👍 😃 🎉 Can you please fix the two remaining CSS bugs (see comments above)? I'm not sure how to replace I'll merge this PR afterwards. Again, great work! 👍 |
Okay, I'll get those two sections fixed in the next few minutes (unless that margin thing causes issues). |
Yeah, the overlap was what I made this style to solve. It's a style applied to I'm not seeing any problem with |
All good things are worth waiting for 😆 Again, amazing work, thank you @smcdougall! 👍 🎉 |
@smcdougall, what do you think about adding a large "Learn more" button on both the start page and our |
Thanks. I've been happy to help. Hopefully this page will help bring even more users to Pico. 😄 Personally, it's a good time for me to have this finished... This Wednesday will be the last day at my current job, and so the current "Productivity time" that I have will be going away. For the moment, I'm taking up my old (retail) job, that way I don't miss a paycheck. This means I'm going to have a bit less time to work with the Pico project every week, but in no way means that I'm going away. After all, I've still got plenty of "projects" around here to work on. 😉 I'll probably still be watching GitHub like a hawk, but if I happen to disappear for a few days at a time, I've likely just been busy with work and I'll be back soon. 😅 |
Sure, why not. 😄 |
By "start page" do you mean the landing page (eg picocms.org)? How large of a button? Something that fits in or something large and flashy like a starburst in the corner? Got to go for now, but let me know what you've got in mind. 😄 |
Ok, thanks for letting me know. May you do well in your new/old job! 👍 😃
Something like 1bf1570 and e59d2d1. Any suggestions (especially for the |
Thanks. It's going well so far, but I am not used to working this hard anymore. My first real day was quite the workout (:dizzy_face:), but it felt pretty good. Hmm... how about this for the readme:
|
As suggested by @smcdougall (#352 (comment))
Glad you approve. 😃 👍 |
Sure 😃 |
The `overlay` style from picocms#352 has been broken since the conversion to CSS Transitions. This style is currently unused, but now it has styles in case we want to use it in the future.
Reissuing this PR since @PhrozenByte goofed. 😉
View the current page at:
http://smcdougall.github.io/Pico/about/
Old Discussion at: #349