Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parsedown extension #318

Closed
wants to merge 1 commit into from
Closed

parsedown extension #318

wants to merge 1 commit into from

Conversation

dav-m85
Copy link
Contributor

@dav-m85 dav-m85 commented Jan 23, 2016

I needed a way of extending the Parsedown extension, hence this PR. Not sure if it is the proper way though.

@PhrozenByte
Copy link
Collaborator

A plugin developer shouldn't be able to replace the Markdown parser with something different (what would be possible with a Pico::setParsedown() method). Unfortunately I don't have a ironclad solution either. You can find my current ideas in #317 (3rd item of "Event system"). I really appreciate your feedback about those ideas!

@PhrozenByte PhrozenByte mentioned this pull request Feb 7, 2016
Open
@PhrozenByte PhrozenByte mentioned this pull request Mar 3, 2016
Merged
41 tasks
@PhrozenByte PhrozenByte closed this Sep 4, 2016
@PhrozenByte
Copy link
Collaborator

We'll implement this feature by adding a new onParsedownRegistered(Parsedown $parsedown) event to Pico 1.1. Please refer to #334 for further discussions about this.

@PhrozenByte PhrozenByte mentioned this pull request May 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: Rejected type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dav-m85 @PhrozenByte