Update App.js #30
Open
Update App.js #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tungtaiwan
approved these changes
Jun 30, 2022
|
Ok |
RamadanHash
approved these changes
Jul 1, 2022
|
👌 |
|
77890665^77906000864 |
1 similar comment
|
merge |
|
Very good network pi |
|
"ok" |
|
Instead of importing every package separately for langauge you should better import all at once using import {package name} from 'whatever package is. So in your case you should be doing --> import {pt, it, ne }from 'react-intl/locale-data.. This will optimise your code and duplicacy as well. This should work and if you think this is wrong please let me know why so that I will also understand. Because as I use functional component so I use this. Thanks. |
|
gh pr checkout 30 |
1 similar comment
|
gh pr checkout 30 |
Koubek11
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update App.js Korean.