Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of added peak index to int (vs current np.int64) #77

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

smoia
Copy link
Member

@smoia smoia commented Aug 22, 2024

Closes #76

Proposed Changes

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added the BugFIX This PR generally closes a "Bug" issue, and increments the patch version (0.0.+1) label Aug 22, 2024
@smoia smoia requested a review from me-pic August 22, 2024 10:04
@smoia smoia requested a review from maestroque August 22, 2024 10:04
@smoia smoia merged commit c0d07f2 into physiopy:master Aug 22, 2024
3 checks passed
@smoia smoia deleted the fix/history branch August 22, 2024 10:07
@smoia
Copy link
Member Author

smoia commented Aug 22, 2024

🚀 PR was released in 0.5.1 🚀

@smoia smoia added the released This issue/pull request has been released label Aug 22, 2024
@me-pic me-pic mentioned this pull request Aug 22, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BugFIX This PR generally closes a "Bug" issue, and increments the patch version (0.0.+1) released This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

save_history fails with TypeError
1 participant