-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created script to resolve phylorefs using the Open Tree of Life APIs #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be missing something but it doesn't seem like you're testing non-resolving phylorefs, nor malformed queries raising the expected error.
Thanks for pointing this out, @hlapp! I've added four additional tests:
Are there any other cases we should test for? |
@gaurav as commented in a previous PR, can I please ask you to rebase first for merge ability so that you are asking me to review what would actually get merged. Right now as a reviewer I can't know that. |
Also updated package-lock.json.
Co-authored-by: Hilmar Lapp <[email protected]>
This is so that we can test for the not-found error from the Open Tree of Life.
Sorry, Github said that "This branch has no conflicts with the base branch", which I assumed meant that it was mergeable. I've now run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this though please consider the one in-line comment I left.
Github/Travis CI integration seems to be acting up right now, but the final commit (f03a1f6) has passed testing on TravisCI at https://travis-ci.org/github/phyloref/phyx.js/builds/742347928. I'm going to go ahead and merge it. |
Added a script that can be used to resolve multiple Phyx files against the Open Tree of Life using their updated MRCA API (#45). Also fixes Travis CI testing, which broke unexpectedly.