Merge pull request #259 from janvernieuwe/issue-258

Fix getClass issue due to bad return types
phpro · Oct 25, 2019 · edb99c5 · edb99c5
2 parents 42a39af + 5ec8941
commit edb99c5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/grumphp.yml b/grumphp.yml
@@ -14,7 +14,7 @@ parameters:
         phpunit: ~
         phplint: ~
         phpstan:
-            level: 4
+            level: 3
             configuration: "phpstan.neon"
             ignore_patterns:
                 - "spec/"

diff --git a/src/Phpro/SoapClient/CodeGenerator/ClientGenerator.php b/src/Phpro/SoapClient/CodeGenerator/ClientGenerator.php
@@ -41,7 +41,7 @@ public function __construct(RuleSetInterface $ruleSet)
      */
     public function generate(FileGenerator $file, $client): string
     {
-        $class = $file->getClass() ?? new ClassGenerator();
+        $class = $file->getClass() ?: new ClassGenerator();
         $class->setNamespaceName($client->getNamespace());
         $class->setName($client->getName());
         $methods = $client->getMethodMap();

diff --git a/src/Phpro/SoapClient/CodeGenerator/TypeGenerator.php b/src/Phpro/SoapClient/CodeGenerator/TypeGenerator.php
@@ -39,7 +39,7 @@ public function __construct(RuleSetInterface $ruleSet)
      */
     public function generate(FileGenerator $file, $type): string
     {
-        $class = $file->getClass() ?? new ClassGenerator();
+        $class = $file->getClass() ?: new ClassGenerator();
         $class->setNamespaceName($type->getNamespace());
         $class->setName($type->getName());