fix: compile filter string params not add quotes

phppkg · Nov 16, 2021 · 5615bee · 5615bee
1 parent dc9dcf6
commit 5615bee
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/Compiler/AbstractCompiler.php b/src/Compiler/AbstractCompiler.php
@@ -130,7 +130,7 @@ protected function parseInlineFilters(string $echoBody): string
                     } elseif ($arg[0] === '$') {
                         $fmtArgs[] = $arg;
                     } else {
-                        $fmtArgs[] = Str::shellQuote($arg);
+                        $fmtArgs[] = Str::paramQuotes($arg);
                     }
                 }
 

diff --git a/test/Compiler/PregCompilerTest.php b/test/Compiler/PregCompilerTest.php
@@ -129,7 +129,11 @@ public function testCompile_inline_echo_with_filters():void
         foreach ($tests as [$in, $out]) {
             $this->assertEquals($out, $p->compile($in));
         }
+    }
 
+    public function testCompile_disableEchoFilter():void
+    {
+        $p = new PregCompiler();
         $p->disableEchoFilter();
 
         $tests = [
@@ -139,6 +143,10 @@ public function testCompile_inline_echo_with_filters():void
                 '{{ $name ?: "inhere" | substr:0,3 }}',
                 '<?= substr($name ?: "inhere", 0,3) ?>'
             ],
+            [
+                '{{ $name | append:, }}',
+                "<?= append(\$name, ',') ?>"
+            ],
             ['{{ some_func() | raw }}', '<?= some_func() ?>'],
         ];
         foreach ($tests as [$in, $out]) {