Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add link to source to composer.json #18

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

localheinz
Copy link
Contributor

This pull request

  • adds a link to the source to composer.json

Follows php-fig/simple-cache#31.

πŸ’β€β™‚οΈ For reference, see https://getcomposer.org/doc/04-schema.md#support.

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, seems like a good idea to me for when people installed this without git and therefore the link to the source is lost.

@localheinz
Copy link
Contributor Author

@dbu

It's also nice for people who navigate to composer.json of this package when they install it with composer and want to navigate to the source.

Currently there are some packages in the @php-fig organization that use the homepage field to link to the package, others use the homepage field to link to https://www.php-fig.org.

@dbu dbu merged commit fc528df into php-fig:master Sep 23, 2023
@dbu
Copy link
Member

dbu commented Sep 23, 2023

@localheinz localheinz deleted the feature/source branch September 23, 2023 15:39
@localheinz
Copy link
Contributor Author

Thank you, @dbu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants