Add support for enqueue 0.10 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just saw this duplicates #7 |
|
can you drop all versions except for 0.10 please? They are not supported. |
Let's update and see what happens |
bfontaine
force-pushed
the
enqueue-0.9-0.10
branch
from
ef9ac69
to
eee4259
Compare
|
ok, done. |
|
Well as-is it doesn’t work because of php-enqueue/enqueue-dev#1136. This code was removed in php-enqueue/enqueue-dev@ed707fe5 for 0.9.0. I’m not sure what to use now that it’s gone; I don’t see it in |
|
Sorry, I don't remember what it was about. |
bfontaine
changed the title
|
The Magento module depends on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per php-enqueue/enqueue-dev#1321 (comment) (cc @makasim)
I’m not sure how to test this. The contribution guide in enqueue-dev mention commands that don’t exist in this repo (and it’s not listed as a split repo).