feat: use Laravel's built-in Manager class #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leeqvip plz review |
leeqvip
requested changes
Jul 4, 2024
src/Loaders/LoaderManager.php
Outdated
| * | ||
| * To utilize a built-in or custom loader, set 'model.config_type' in the configuration to match one of the above types. | ||
| */ | ||
| class LoaderManager extends Manager |
There was a problem hiding this comment.
Please rename it to ModelLoaderManager
src/LauthzServiceProvider.php
Outdated
Comment on lines
61
to
78
| $this->registerGates(); | ||
| } | ||
|
|
||
| /** | ||
| * Register a gate that allows users to use Laravel's built-in Gate to call Enforcer. | ||
| * | ||
| * @return void | ||
| */ | ||
| protected function registerGates() | ||
| { | ||
| Gate::define('enforcer', function ($user, ...$args) { | ||
| $identifier = $user->getAuthIdentifier(); | ||
| if (method_exists($user, 'getAuthzIdentifier')) { | ||
| $identifier = $user->getAuthzIdentifier(); | ||
| } | ||
| $identifier = strval($identifier); | ||
|
|
||
| return Enforcer::enforce($identifier, ...$args); |
Dobmod
force-pushed
the
feature-more-built-in-0.1
branch
from
320a77c to
62f8de5
Compare
- Use Laravel's built-in abstract Manager class instead of ModelLoaderFactory (php-casbin#71)
Dobmod
force-pushed
the
feature-more-built-in-0.1
branch
from
62f8de5 to
fe5839f
Compare
Dobmod
changed the title
leeqvip
approved these changes
Jul 5, 2024
|
🎉 This issue has been resolved in version 3.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: use Laravel's built-in Manager class