-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: loading model from remote url #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@leeqvip plz review |
leeqvip
requested changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And please add unit tests
Unit tests added. |
@rev3z Please fix the ci check error. |
I'll fix it! |
rev3z
force-pushed
the
feat-remote-model
branch
2 times, most recently
from
June 14, 2024 13:54
ed659e0
to
419859d
Compare
CI error fixed, PR contents updated. |
@leeqvip plz review |
leeqvip
approved these changes
Jun 15, 2024
🎉 This PR is included in version 3.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an enhancement to enhance the flexibility of the Enforcer's model management:
Remote Model Initialization via URL: This feature enables the Enforcer to fetch its model configuration from a remote URL at startup.
Refactoring with Factory Pattern for Model Loading: To streamline and abstract the complexity of model loading processes, a new ModelLoaderFactory class has been introduced.
Upon initialization, the system not only supports fetching plain text model configurations from URLs but also sets the stage for more sophisticated content handling through custom implementations of
\Lauthz\Loaders\ModelLoader
, catering to diverse content types like JSON.Related Issues
[Question] Loading model from a remote URL #15
Details