Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

✨ 🐧 Allow implementation of a user invitation to fix settings #2848

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JayceeZ
Copy link

@JayceeZ JayceeZ commented Oct 28, 2019

Description

Added OPEN_NOTIFICATIONS_SETTINGS intent trigger method along with Importance and SoundUri values to allow implementation of a user invitation to fix settings:
https://developer.android.com/training/notify-user/channels#UpdateChannel

Related Issue

#2847

Motivation and Context

In our own project, we need to be able to open Intent related to Channel settings.
Please see https://developer.android.com/training/notify-user/channels#UpdateChannel
for more details over this need.

How Has This Been Tested?

Tested in our project, not sure how we should proceed for testing. Could be Spy call checks like existing methods, however I have noticed some methods are untested. Due to it's Android only nature.

Screenshots (if appropriate):

Types of changes

[x] New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All -new and- existing tests passed.

…h Importance and SoundUri values to allow implementation of a user invitation to fix settings:

https://developer.android.com/training/notify-user/channels#UpdateChannel
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant