Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass fromEl and toEl to hook beforeUpdate #3616

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Draft

pass fromEl and toEl to hook beforeUpdate #3616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/js/phoenix_live_view/view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ export default class View {
let hook = this.getHook(fromEl)
let isIgnored = hook && DOM.isIgnored(fromEl, this.binding(PHX_UPDATE))
if(hook && !fromEl.isEqualNode(toEl) && !(isIgnored && isEqualObj(fromEl.dataset, toEl.dataset))){
hook.__beforeUpdate()
hook.__beforeUpdate(fromEl, toEl)
return hook
}
}
Expand Down
2 changes: 1 addition & 1 deletion assets/js/phoenix_live_view/view_hook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default class ViewHook {

__mounted(){ this.mounted && this.mounted() }
__updated(){ this.updated && this.updated() }
__beforeUpdate(){ this.beforeUpdate && this.beforeUpdate() }
__beforeUpdate(fromEl, toEl){ this.beforeUpdate && this.beforeUpdate(fromEl, toEl) }
__destroyed(){
this.destroyed && this.destroyed()
DOM.deletePrivate(this.el, HOOK_ID) // https://github.com/phoenixframework/phoenix_live_view/issues/3496
Expand Down
Loading