Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rendering nil #251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow rendering nil #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/phlex/rails/sgml.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ def render(*args, **kwargs, &block)
return super if renderable < Phlex::SGML
when Enumerable
return super unless ActiveRecord::Relation === renderable
when nil
return super if kwargs.length == 0
end

return super if args.length == 0 && kwargs.length == 0
Expand Down
2 changes: 2 additions & 0 deletions test/dummy/app/views/rendering/standard_phlex.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
module Rendering
class StandardPhlex < ApplicationView
def view_template
render nil

render Header do
h1(id: "title") { "Hello Phlex!" }
end
Expand Down
Loading