-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require long-form partial rendering #223
Conversation
lib/phlex/rails/sgml.rb
Outdated
renderable = args[0] | ||
partial = kwargs.delete(:partial) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this move down to the when nil
clause?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just caught that myself. Pushed up a change.
991abcd
to
7458c4d
Compare
Yay! This cleans up a bunch of weird things I had to do in Rails to have Phlex render a string value. |
I'm late to the party here, but I just noticed that it's needed to be called like this:
which, AFAIK, wouldn't work in ActionView, it would require the
is it worth noting this inconsistency somewhere? |
Agh, that's annoying. I wonder if it would be better for us to support this instead
|
That would be more consistent, but I think it just boils down to adding it to the docs |
Thanks for catching this. We should get it right before the 2.0 release. |
Closes #137
In order to render a partial, you must pass it as the
partial:
keyword argument.