Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rails-version-specific sqlite3 gem versions #218

Merged

Conversation

mjankowski
Copy link
Contributor

As mentioned here - #217 (comment) - there are some CI and local failures in the repo now b/c the newer rails-edge appraisal run expects sqlite3 gem version 2.x, but we have 1.7 specified in the Genfile (and thus inherited by the appraisal gemfiles). Changes here:

  • Relax the main Gemfile to not include a version, which will default to the later versions, which presumably makes sense for anyone doing local non-appraisal-run development?
  • Update the appraisals to lock to 1.7 for rails-7 path and 2.x for the rails-edge path

For me locally this gets the previously failing appraisal test run to pass w/out the sqlite3 version conflict error ... assume same will occur on CI.

@joeldrapper joeldrapper merged commit 5784122 into phlex-ruby:main Aug 27, 2024
13 checks passed
@mjankowski mjankowski deleted the appraisal-sqlite3-gem-versions branch August 27, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants