Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'build.sh: command not found' when running inside container #10

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

grzuy
Copy link
Contributor

@grzuy grzuy commented Oct 31, 2023

It seems this is necessary when running the action in a job that sets a container image.
It can't find the build.sh scripts otherwise.

Possible discussion about this bug: actions/runner#1762 (comment)

https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runsstepsrun
https://docs.github.com/en/actions/learn-github-actions/contexts#github-context

@grzuy
Copy link
Contributor Author

grzuy commented Nov 3, 2023

Needed this in mimiquate/candlex#16 in order to make it work when running action inside nvidia/cuda container.

@philss philss merged commit a62ca47 into philss:main Nov 3, 2023
@philss
Copy link
Owner

philss commented Nov 3, 2023

@grzuy Thank you! 💜
Please try the version from main.

@grzuy grzuy deleted the fix-build-sh-with-container branch November 3, 2023 15:50
@grzuy
Copy link
Contributor Author

grzuy commented Nov 3, 2023

@grzuy Thank you! 💜 Please try the version from main.

All good https://github.com/mimiquate/candlex/actions/runs/6747190695/job/18342776166 ✔️

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants