Skip to content

Commit

Permalink
fix external url
Browse files Browse the repository at this point in the history
  • Loading branch information
Phikho-cc committed Nov 1, 2024
1 parent f745353 commit d568246
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/components/Portfolio.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ function Portfolio() {
<ProjectCard
key={index}
{...project}
onButtonClick={() => project.videoUrl ? openModal(project.videoUrl) : window.open(project.linkUrl, "_blank")}
onButtonClick={() => project.videoUrl ? openModal(project.videoUrl) : window.open(project.externalUrl, "_blank")}
/>
))}
</div>
Expand Down
1 change: 1 addition & 0 deletions src/constants/ProjectList.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ const projectList = [
description: "A data science project that uses web-scraping, RESTful API and machine learning to predict housing prices and assess real estate trends from extensive data.",
buttonLabel: "GitHub Link",
linkUrl: dsPDF,
externalUrl: "https://github.com/MAST30034-Applied-Data-Science/generic-real-estate-consulting-project-group-43"
}
];

Expand Down

0 comments on commit d568246

Please sign in to comment.