Add top-navbar with useful links. #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jwaxo
approved these changes
Dec 20, 2017
frontend/src/components/App.vue
Outdated
| <li class="nav-item"><a class="nav-link" href="http://slack.outrigger.sh/">Join us on Slack</a></li> | ||
| <li class="nav-item dropdown"> | ||
| <a class="nav-link dropdown-toggle" href="#" id="supportDropdown" role="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"> | ||
| File an Issue |
|
Okay, made a few more tweaks. Here's what I got now: Desktop (Collapsed issues dropdown)
Mobile (Expanded issues dropdown)
|
|
Now that I got #8 working, I found this breaks the dashboard, tables below the top DNS Records are all inline and squished. |
Jwaxo
reviewed
Dec 21, 2017
| @@ -1,5 +1,5 @@ | |||
| <template> | |||
| <div class="col project table-responsive"> | |||
| <div class="project table-responsive"> | |||
There was a problem hiding this comment.
So did this clear up the "squishing" issue?
There was a problem hiding this comment.
This part fixed each project's table being on the same horizontal row. Looks good on chrome at least.. I guess I should check others.
grayside
commented
Dec 21, 2017
| </nav> | ||
|
|
||
| <header class="jumbotron"> | ||
| <h1 class="display-3 mt-5">Outrigger Dashboard</h1> |
There was a problem hiding this comment.
mt-5 stands for margin top 5, where 5 is multiplied by some kind of predefined spacer and unit of measurement. display-3 addresses some sizing issues after I pulled out the extra markup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phase2/rig#126
I'm not sure I like the way the header looks, but the navbar seems nice. Incidentally adds more JS and upgrades to Bootstrap 4.