-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor adjustments and tweaks #434
Merged
Merged
Changes from 22 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
7fbdaee
feat(adopted-stylesheets): Make `AdoptedStyleSheets` controller more …
himerus 6328804
fix(adopted-stylesheets): Throw an error if no root is present.
himerus ce0cacf
Merge branch 'next' into feature/adopted-stylesheets-update
glitchgirl 12be159
feat(adopted-stylesheets): Tweaked docs.
himerus 6bafd84
feat(adopted-stylesheets): Comment update.
himerus 58dff7b
Merge branch 'next' into feature/adopted-stylesheets-update
himerus 41c46cf
feat(adopted-stylesheets): Adjustments to README.
himerus 568a692
feat(adopted-stylesheets): Make passing `document` optional and the d…
himerus 3dbe9bb
feat(adopted-stylesheets): Updated documentation.
himerus 87329bb
feat(tooling): Updated GitHub Actions.
himerus ffe4890
Merge branch 'next' into feature/action-updates
himerus 9aade98
chore(diff): Update yarn.lock.
himerus b448d69
feat(actions): Update installations/setup.
himerus 0b20790
feat(actions): Use local yarn version.
himerus 38ae743
feat(actions): Update step ordering.
himerus ea2fe53
feat(actions): Switching to node:lts container image for testing.
himerus 2e9d54c
feat(tooling): Tweaking setup to simplify CSS and component builds.
himerus d5637cd
Merge branch 'next' into feature/adopted-stylesheets-update
himerus fad8aba
Merge branch 'feature/adopted-stylesheets-update' into feature/action…
himerus b8f9361
feat(tooling): Moved all deprecated packages to a more friendly folde…
himerus 66b1168
feat(tooling): fix for broken deps and linting.
himerus 8cf9103
feat(tooling): Adjusting for storybook build and css setup.
himerus 755e9e3
feat(tooling): Refactor for many package deps.
himerus 7bbfee4
feat(tooling): Adjusting action.
himerus d7a3cfb
feat(tooling): Remove need for `rsync` call.
himerus 94d9260
feat(tooling): Wiped deprecated packages to move to new location.
himerus 226c27a
feat(tooling): Remove comments.
himerus f20dca0
fix(styles): Adjust CSS setup.
himerus c34b007
fix(outline-alert): Prepare for initial release.
himerus ce4612e
fix(changeset): Adding changesetl.
himerus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,4 +18,4 @@ storybook-static/ | |
.yarn/ | ||
project/ | ||
*.d.ts | ||
packages/tools/outline-cli/ | ||
packages/deprecated |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
@import url('https://rsms.me/inter/inter.css'); | ||
/* Outline */ | ||
@import '../packages/outline-templates/default/outline.theme.css'; | ||
@import '../outline.theme.css'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,10 +13,9 @@ | |
"workspaces": [ | ||
"./packages/*", | ||
"./packages/components/*", | ||
"./packages/components/@deprecated/*", | ||
"./packages/deprecated/*", | ||
"./packages/documentation/*", | ||
"./packages/controllers/*", | ||
"./packages/controllers/@deprecated/*", | ||
"./packages/tools/*", | ||
"./docs" | ||
], | ||
|
@@ -34,18 +33,19 @@ | |
"license": "BSD-3-Clause", | ||
"scripts": { | ||
"analyze": "yarn build && wca analyze 'packages/**/*.ts' --outFiles '{dir}/../README.md'", | ||
"build": "turbo run build --concurrency=100% --filter=!./packages/**/@deprecated/*", | ||
"build": "turbo run build --concurrency=100%", | ||
"changeset": "changeset", | ||
"changeset:publish": "yarn build && yarn changeset:version && yarn changeset publish", | ||
"changeset:version": "changeset version", | ||
"chromatic": "chromatic --build-script-name storybook:build --exit-zero-on-changes --skip '@(renovate/**|dependabot/**)'", | ||
"clean": "npm-run-all -s clean:*", | ||
"clean": "npm-run-all -p clean:*", | ||
"clean:dist": "rimraf dist && rimraf packages/**/dist", | ||
"clean:turbo": "rimraf packages/**/.turbo", | ||
"clean:storybook": "rimraf storybook-static", | ||
"clean:css": "rimraf packages/**/*.lit.*", | ||
"clean:maps": "rimraf packages/**/*.map", | ||
"clean:types": "rimraf packages/**/*.d.ts", | ||
"dev": "yarn watch", | ||
"fix": "yarn format && yarn lint", | ||
"format": "npm-run-all -s format:*", | ||
"format:code": "eslint --fix . && prettier --write .", | ||
|
@@ -56,23 +56,18 @@ | |
"lint:tsc": "tsc --noEmit", | ||
"lint:prettier": "prettier --check .", | ||
"package": "turbo run package --filter=!./packages/**/@deprecated/*", | ||
"prep": "npm-run-all -s prep:*", | ||
"prep:css": "node scripts/styles.js", | ||
"prebuild": "yarn prep", | ||
"prestart": "yarn prep", | ||
"rebuild": "yarn reset && yarn build", | ||
"reset": "yarn clean && npm-run-all -s reset:*", | ||
"reset:packages": "rimraf packages/**/node_modules", | ||
"reset:root": "rimraf ./node_modules", | ||
"reset:root": "rimraf node_modules", | ||
"reset:install": "yarn install", | ||
"restart": "yarn reset && yarn start", | ||
"start": "yarn watch", | ||
"start": "yarn dev", | ||
"storybook": "storybook", | ||
"storybook:build": "storybook build", | ||
"test": "turbo run test", | ||
"watch": "npm-run-all -p watch:*", | ||
"watch:storybook": "yarn storybook dev -p ${npm_package_storybook_port}", | ||
"watch:css": "node scripts/styles.js --watch" | ||
"watch:storybook": "yarn storybook dev -p ${npm_package_storybook_port}" | ||
}, | ||
"keywords": [ | ||
"web-components", | ||
|
@@ -136,5 +131,8 @@ | |
}, | ||
"readme": "ERROR: No README data found!", | ||
"homepage": "https://github.com/phase2/outline#readme", | ||
"_id": "@phase2/[email protected]" | ||
"_id": "@phase2/[email protected]", | ||
"dependencies": { | ||
"lit": "^3.1.2" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
import { html, TemplateResult, CSSResultGroup } from 'lit'; | ||
import { html, TemplateResult } from 'lit'; | ||
import { customElement } from 'lit/decorators.js'; | ||
|
||
// Our base component, which all others extend. | ||
import { OutlineElement } from '@phase2/outline-core'; | ||
|
||
import componentStyles from './outline-core-accordion.css.lit'; | ||
// import componentStyles from './outline-core-accordion.css.lit'; | ||
|
||
/** The element name, reused throughout the codebase */ | ||
const componentName = 'outline-core-accordion'; | ||
|
@@ -26,7 +26,7 @@ const componentName = 'outline-core-accordion'; | |
*/ | ||
@customElement(componentName) | ||
export class OutlineCoreAccordion extends OutlineElement { | ||
static styles: CSSResultGroup = [componentStyles]; | ||
// static styles: CSSResultGroup = [componentStyles]; | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Commenting out the assignment of styles removes the component's styling. If this is intentional, consider removing the code instead of commenting it out for cleaner code. |
||
render(): TemplateResult { | ||
return html` <slot></slot> `; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting out the import of component styles will prevent the component from being styled as intended. Ensure this is the desired behavior.