Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding stylelint #364

Closed
wants to merge 2 commits into from
Closed

feat: adding stylelint #364

wants to merge 2 commits into from

Conversation

shaal
Copy link
Contributor

@shaal shaal commented Nov 29, 2022

Description

CSS structure is very different between components / projects.
We should add stylelint (used by Drupal core - https://www.drupal.org/node/2868114) to organize CSS files.

@todo, we should rename the extension of all source CSS files to pcss.css, then it's easier to target these files (vs. compiled CSS file which would be .css.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Visual Testing
  • Automated Testing
  • Accessibility Testing

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shaal shaal self-assigned this Nov 29, 2022
@changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2022

⚠️ No Changeset found

Latest commit: 9fae206

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for outlinejs ready!

Name Link
🔨 Latest commit 9fae206
🔍 Latest deploy log https://app.netlify.com/sites/outlinejs/deploys/646bad0c282d8d00085c0c7b
😎 Deploy Preview https://deploy-preview-364--outlinejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
[email protected] filesystem, environment +29 mattxwang
[email protected] None +31 ybiquitous
[email protected] None +0 mhmadhamster
[email protected] None +31 hudochenkov

Copy link
Contributor

@himerus himerus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note, these changes currently on working on Outline itself. We will need to port/extend a solution to outline-templates to make this "complete", and to ensure all projects are utilizing this methodology and this configuration.

@glitchgirl
Copy link
Contributor

glitchgirl commented Feb 6, 2024

using prettier instead
#397

@glitchgirl glitchgirl closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants