-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify building rcmd matrix #192
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't think @bms63 likes to see this kind of stuff in the PR check status: I'll leave it for him and others to decide. Technically this is okay for me though. |
You are right. I added the name to the job, |
Haha yes I prefer if we could hide this step from the developers. We tend to have newer folks to this stuff and it can be a bit overwhelming having so many CI jobs. IS there any way to fold it into the R CMD Check? However, I must admit I don't understand what the issue that is being solved here? Can someone please explain? We have some others ask for R-CMD checks and worries out snapshots not being checked as well. |
This PR is generated matrix before execution.
In the current situation, we were showing the job as complete.
With this PR we executed devel only on initial condition.
@cicdguy kindly asked for review.