-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2481 bug the result of derive param tte depends on the sort order of the input #2569
base: main
Are you sure you want to change the base?
2481 bug the result of derive param tte depends on the sort order of the input #2569
Commits on Nov 18, 2024
-
Added order arguments to censor_source and event_source. Also added s…
…ignal_duplicate_records to derive_param_tte. Still troubleshooting the test-derive_param_tte script. Failed tests have a "Required variable `AEDECOD` is missing in `dataset`" error.
Configuration menu - View commit details
-
Copy full SHA for 8e23388 - Browse repository at this point
Copy the full SHA 8e23388View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd52801 - Browse repository at this point
Copy the full SHA cd52801View commit details -
Fixed previous erros but still need to address failed tests for Test …
…9, 15, and 16 in test-derive_param_tte
Configuration menu - View commit details
-
Copy full SHA for 2727736 - Browse repository at this point
Copy the full SHA 2727736View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e86217 - Browse repository at this point
Copy the full SHA 9e86217View commit details -
Changed position of signal_duplicate_records function in derive_param…
…_tte to fix missing data error
Configuration menu - View commit details
-
Copy full SHA for d97377c - Browse repository at this point
Copy the full SHA d97377cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa49a51 - Browse repository at this point
Copy the full SHA fa49a51View commit details -
Pushing again and confirmed check_type argument is in derive_var_obs_number in derive_joined.R scripts
Configuration menu - View commit details
-
Copy full SHA for 01e8f5a - Browse repository at this point
Copy the full SHA 01e8f5aView commit details
Commits on Nov 19, 2024
-
updated NEWS.md with changes to derive_param_tte,. Removed Test 17 fr…
…om test-derive_param_tte as it was redundant, and ran pharmaverse4devs format test script addin to format testest-derive_param_tte.
Configuration menu - View commit details
-
Copy full SHA for 53457c2 - Browse repository at this point
Copy the full SHA 53457c2View commit details -
Merge branch 'main' into 2481-bug-the-result-of-derive_param_tte-depe…
…nds-on-the-sort-order-of-the-input
Configuration menu - View commit details
-
Copy full SHA for 020c9d7 - Browse repository at this point
Copy the full SHA 020c9d7View commit details -
changed the signal_duplicate_records within derive_parame_tte to hand…
…le dataset_adsl and source_datasets by combining them with bind_rows before to address error of AEDECOD missing from the dataset when just calling dataset_adsl. This starts on line 381 of derive_param_tte.R
Configuration menu - View commit details
-
Copy full SHA for dccdbe1 - Browse repository at this point
Copy the full SHA dccdbe1View commit details -
Merge branch '2481-bug-the-result-of-derive_param_tte-depends-on-the-…
…sort-order-of-the-input' of https://github.com/pharmaverse/admiral into 2481-bug-the-result-of-derive_param_tte-depends-on-the-sort-order-of-the-input
Configuration menu - View commit details
-
Copy full SHA for 8006891 - Browse repository at this point
Copy the full SHA 8006891View commit details
Commits on Nov 21, 2024
-
added a tryCatch() to filter_date_sources to catch duplicates to addr…
…ess failed runs in Test 16 of test-derive_param_tte. removed signal_duplicate_records() from within derive_param_tte Still need to troubleshoot errors in test script.
Configuration menu - View commit details
-
Copy full SHA for 4c95243 - Browse repository at this point
Copy the full SHA 4c95243View commit details
Commits on Nov 24, 2024
-
Moved duplication check to filter_date_sources in tryCatch() and rewr…
…ote Test 15 and 16 on test-derive_param_tte to deal with update to duplicate warnings within tryCatch and not directly by signal_duplicate_records inside derive_param_tte function. Accepted snapshots from devtools::check
Configuration menu - View commit details
-
Copy full SHA for 087c0f3 - Browse repository at this point
Copy the full SHA 087c0f3View commit details