Skip to content

Commit

Permalink
[skip vbump] Closes #2459 feedback from cran for admiral 110 (#2460)
Browse files Browse the repository at this point in the history
* Increment version number to 1.2.0

* fix: #2459 CRAN findings; minor version fixed;

* chore: #2459 news my life away

* docs: #2459 cran feedback on truncated line
  • Loading branch information
bms63 authored Jun 7, 2024
1 parent b72d79d commit a1eb19b
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 6 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: admiral
Title: ADaM in R Asset Library
Version: 1.1.0.9001
Version: 1.1.0
Authors@R: c(
person("Ben", "Straub", , "[email protected]", role = c("aut", "cre")),
person("Stefan", "Bundfuss", role = "aut"),
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# admiral 1.1.0.9001
# admiral 1.1.0

## New Features
- Added helper functions to `derive_vars_merged()` (`get_flagged_records()`) and `derive_vars_query()` (`get_vars_query()`) so that those can be called independently as per user's request. `derive_vars_merged()` function call results are not impacted by the change (#2441).
Expand Down
6 changes: 5 additions & 1 deletion R/duplicates.R
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,11 @@ extract_duplicate_records <- function(dataset, by_vars) {
#' signal_duplicate_records(adsl, exprs(USUBJID), cnd_type = "message")
signal_duplicate_records <- function(dataset,
by_vars,
msg = "Dataset contains duplicate records with respect to {.var {replace_values_by_names(by_vars)}}", # nolint
msg = paste(
"Dataset contains duplicate records",
"with respect to",
"{.var {replace_values_by_names(by_vars)}}"
),
cnd_type = "error") {
assert_expr_list(by_vars)
assert_data_frame(dataset, required_vars = extract_vars(by_vars), check_is_grouped = FALSE)
Expand Down
4 changes: 2 additions & 2 deletions man/signal_duplicate_records.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion vignettes/concepts_conventions.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ library(admiraldev)
This vignette aims to discuss some of the common programming concepts and conventions that have been adopted within the
`{admiral}` family of packages. It is intended to be a user-facing version of the [Programming Strategy](https://pharmaverse.github.io/admiraldev/articles/programming_strategy.html) vignette, but users can also read the
latter after becoming more familiar with the package to expand further on any topics of interest. For some of common
`{admiral}` FAQ, visit the corresponding [FAQ page](faq.html).
`{admiral}` FAQ, visit the corresponding FAQ page provided in the same drop down menu
as this vignette.

# Input and Output

Expand Down

0 comments on commit a1eb19b

Please sign in to comment.